Skip to content

Fix: overlaping of "Sign in as a different user" button for small and medium devices#3438

Open
bikalsiwakoti wants to merge 2 commits intodubinc:mainfrom
bikalsiwakoti:fix/ui-small-medium-device
Open

Fix: overlaping of "Sign in as a different user" button for small and medium devices#3438
bikalsiwakoti wants to merge 2 commits intodubinc:mainfrom
bikalsiwakoti:fix/ui-small-medium-device

Conversation

@bikalsiwakoti
Copy link

@bikalsiwakoti bikalsiwakoti commented Feb 8, 2026

Fixes: #3431

Description:
On small and medium screen sizes, the component was overlapping with buttons and text due to position: fixed.
To fix this, I removed position: fixed specifically for small and medium devices and centered the component instead.

Before:
Screenshot 2026-02-08 190913

This ensures:

  • No overlapping of buttons or text
  • Better alignment on small and medium screens
  • No changes to large screen behavior

Only small and medium device styles were updated; desktop layout remains unchanged.

After:
image
I think it looks better in the center and just below of the "Create Workspace" button.
Just let me know if i can make it better.

Summary by CodeRabbit

  • Style
    • Enhanced responsive layout adjustments in the onboarding experience. Small screens now display with optimized top spacing, while large screens receive additional bottom spacing and improved positioning for better visual balance across devices.

@vercel
Copy link
Contributor

vercel bot commented Feb 8, 2026

@bikalsiwakoti is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

These changes fix mobile layout issues in the onboarding flow by converting a fixed-positioned component to use responsive positioning and adjusting padding distribution across screen breakpoints. Only CSS/styling modifications are made; no runtime logic or event handling changes.

Changes

Cohort / File(s) Summary
Onboarding Responsive Layout Fixes
apps/web/app/app.dub.co/(onboarding)/signed-in-hint.tsx, apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/layout.tsx
Adjusted responsive positioning and padding to resolve mobile layout fitting issues: converted fixed bottom-left positioning to static with responsive breakpoint adjustments in signed-in-hint, and changed padding from uniform vertical (py-16) to breakpoint-specific top/bottom distribution (pt-16 pb-0 lg:pb-16) in layout component.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • steven-tey

Poem

🐰 Hop, hop, the mobile screens now align,
No more overlapping UI—everything's fine!
Responsive padding and positions so true,
From fixed to flowing, a responsive brew.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: addressing button overlap on small and medium devices by removing position: fixed.
Linked Issues check ✅ Passed Changes address #3431 by making the sign-in hint component responsive: removing position: fixed for small/medium screens and adjusting padding in the layout, directly fixing mobile UI overlap issues.
Out of Scope Changes check ✅ Passed All changes are scoped to the identified problem: responsive positioning adjustments to signed-in-hint.tsx and padding adjustments to layout.tsx for small/medium devices.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bikalsiwakoti bikalsiwakoti reopened this Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile UI Not Properly Fitting After Sign-In

2 participants